Add option to not apply instrument- prefix to service names #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option prefix_service, true by default. Necessary because for some reason on lsstcam hosts services are being defined without the prefix, in contrast to eg comcam, which does use the prefix.
glennmorris
force-pushed
the
no-instrument-prefix
branch
from
0044293 to
868f2af
Compare
The old version has disappeared from nexus. Ref eg https://lsstc.slack.com/archives/C01270EHCQ3/p1696349052366809
jhoblitt
approved these changes
Feb 9, 2024
|
Agreed about the tests; but the existing coverage for this module is very basic, and I don't think I know how to add the necessary machinery to test more thoroughly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option prefix_service, true by default. Necessary because for some reason on lsstcam hosts services are being defined without the prefix, in contrast to eg comcam, which does use the prefix.