DM-38660: Add SlackWebException for HTTPX errors #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
astropy/sphinx-automodapi#162 is the issue for missing documentation for exceptions. |
jonathansick
approved these changes
Apr 12, 2023
Provide a SlackWebException base exception class, derived from SlackException, which understands how to extract useful information from HTTPX exceptions so that it can be reported to Slack. It also improves the stringification of HTTPX exceptions, which normally may not include the failing URL in the exception stringification. Unfortunately, automodapi doesn't generate documentation for class or instance methods of exceptions, so the references to from_exception in the docs can't be links to the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a SlackWebException base exception class, derived from SlackException, which understands how to extract useful information from HTTPX exceptions so that it can be reported to Slack. It also improves the stringification of HTTPX exceptions, which normally may not include the failing URL in the exception stringification.
Unfortunately, automodapi doesn't generate documentation for class or instance methods of exceptions, so the references to from_exception in the docs can't be links to the documentation.