Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how to add new pre-commit hooks. #55

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

wvreeven
Copy link
Contributor

@wvreeven wvreeven commented Sep 4, 2023

No description provided.

Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only found 1 typo (see inline comment).

See the other hooks in the registry for examples.
* optional: indicate whether the hook is optional (``True``) or not (``False``).
Setting this to True will still include the hook but will not make the ``generate_pre_commit_conf`` command complain if it is missing.
* excludable: indicate whether the hook can be excluded (``True``) or not (``Talse``).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Talse -> False

@wvreeven wvreeven merged commit 5665104 into main Sep 5, 2023
2 checks passed
@wvreeven wvreeven deleted the tickets/DM-38239 branch September 5, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants