Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-pre-commit-config: Update the develop guide to reflect reality again. #58

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

wvreeven
Copy link
Contributor

@wvreeven wvreeven commented Oct 2, 2023

No description provided.

@wvreeven wvreeven requested a review from couger01 October 2, 2023 14:49
Copy link
Collaborator

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one suggested change for clarification.

* OPT_IN: The rule is optional and does not get included by default.
The majority of the hooks will be of the OPT_IN rule type.
* OPT_OUT: The rule is optional and gets included by default.
Adding such a rule needs to be discussed at TSSW standup first.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adding such a rule needs to be discussed at TSSW standup first.
Adding such a type of hook needs to be discussed at TSSW standup first.

@wvreeven wvreeven merged commit d300c04 into main Oct 2, 2023
2 checks passed
@wvreeven wvreeven deleted the tickets/DM-41001 branch October 2, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants