Update astrometry fail tests

calibrateImage needs a tighter constraint here to produce a failure,
and it's only in one detector/visit.

bin/pipeline.sh

@@ -58,7 +58,7 @@ pipetask --long-log --log-level="$loglevel" qgraph \
     -b "$repo"/butler.yaml \
     --input "$INPUTCOLL" --output "$COLLECTION" \
     -p "$DRP_PIPE_DIR/pipelines/HSC/DRP-ci_hsc.yaml" \
-    -c calibrateImage:astrometry.maxMeanDistanceArcsec=0.025 \
+    -c calibrateImage:astrometry.maxMeanDistanceArcsec=0.020 \
     -c makeWarp:select.maxPsfTraceRadiusDelta=0.2 \
     --save-qgraph "$QGRAPH_FILE"
 

python/lsst/ci/hsc/gen3/data.py

@@ -54,13 +54,12 @@
     {'visit': 903988, 'detector': 24, 'physical_filter': 'HSC-I'},
 ]
 # The following lists the dataIds that fail the astrometry check with
-# the config override calibrate.astrometry.maxMeanDistanceArcsec=0.025
+# the config override calibrate.astrometry.maxMeanDistanceArcsec=0.020
 # set.  This list is sensitive to the astrometry algorithms and dataset
 # under consideration, so may require updating if either of those change
 # in the context of this repository.
 ASTROMETRY_FAILURE_DATA_IDS = [
     {'visit': 903344, 'detector': 0, 'physical_filter': 'HSC-R'},
-    {'visit': 903346, 'detector': 1, 'physical_filter': 'HSC-R'},
 ]
 # The following lists the dataIds that fail the PSF Model robustness check
 # with the config override makeWarp.select.maxPsfTraceRadiusDelta=0.2 set.

tests/test_astrometryFail.py

@@ -36,7 +36,7 @@ def setUp(self):
         self.butler = Butler(os.path.join(getPackageDir("ci_hsc_gen3"), "DATA"), writeable=False,
                              collections=["HSC/calib/2013-06-17", "HSC/runs/ci_hsc"])
         # The dataId here represents one of the astrometry fit failures
-        # imposed by setting astrometry.maxMeanDistanceArcsec: 0.025 in
+        # imposed by setting astrometry.maxMeanDistanceArcsec: 0.020 in
         # the pipeline.
         self.detector = 0
         self.visit = 903344