DM-46991: switch to calibrateImage #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calibrateImage needs a tighter constraint here to produce a failure, and it's only in one detector/visit.
Until we've fully figured out how to handle partial outputs in DRP tasks downstream of calibrateImage, we can't use this to test failed astrometry.
Two PSF modeling failures in finalizeCharacterization that occurred with characterizeImage seem to have gone away with calibrateImage.
natelust
approved these changes
Nov 25, 2024
| ASTROMETRY_FAILURE_DATA_IDS = [ | ||
| {'visit': 903344, 'detector': 0, 'physical_filter': 'HSC-R'}, | ||
| {'visit': 903346, 'detector': 1, 'physical_filter': 'HSC-R'}, | ||
| # {'visit': 903344, 'detector': 0, 'physical_filter': 'HSC-R'}, |
There was a problem hiding this comment.
Why are you leaving a comment in?
There was a problem hiding this comment.
To make it easier to act on the TODO comment a few lines up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.