-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46356: Create new calibration pipelines for IsrTaskLSST for LATISS #267
base: main
Are you sure you want to change the base?
Conversation
c16796b
to
352cd87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think test_latiss_pipelines
has some leftover excludes
that this ticket is resolving.
pipelines/LATISS/cpLinearizer.yaml
Outdated
@@ -1,11 +1,13 @@ | |||
description: cp_pipe linearity calibration construction. | |||
description: cp_pipe linearizer calibration construction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous pipelines have Latiss X calibration construction
.
python/lsst/cp/pipe/_configure.py
Outdated
@@ -0,0 +1,38 @@ | |||
__all__ = ["configureIsrTaskLSSTForCalibrations"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need the file preamble?
tests/test_pipelines.py
Outdated
"cpFringe.yaml", | ||
"cpCti.yaml", | ||
"cpBfk.yaml", | ||
# TODO DM-46356: Remove following from exclusion list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's this ticket. These can be removed now right?
b613f31
to
07f6a1c
Compare
2a27211
to
dc5619d
Compare
dc5619d
to
5bda9d6
Compare
This PR is here to review in conjunction with DM-45856 (#266) and contains all of the commits on that PR. That PR should be merged first and this rebased on top of it. However, this PR is here so that the full tests of those pipelines can be seen in context.