Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46356: Create new calibration pipelines for IsrTaskLSST for LATISS #267

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Sep 18, 2024

This PR is here to review in conjunction with DM-45856 (#266) and contains all of the commits on that PR. That PR should be merged first and this rebased on top of it. However, this PR is here so that the full tests of those pipelines can be seen in context.

Copy link
Contributor

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think test_latiss_pipelines has some leftover excludes that this ticket is resolving.

@@ -1,11 +1,13 @@
description: cp_pipe linearity calibration construction.
description: cp_pipe linearizer calibration construction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous pipelines have Latiss X calibration construction.

@@ -0,0 +1,38 @@
__all__ = ["configureIsrTaskLSSTForCalibrations"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need the file preamble?

"cpFringe.yaml",
"cpCti.yaml",
"cpBfk.yaml",
# TODO DM-46356: Remove following from exclusion list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's this ticket. These can be removed now right?

@erykoff erykoff force-pushed the tickets/DM-46356 branch 12 times, most recently from b613f31 to 07f6a1c Compare September 27, 2024 19:58
@erykoff erykoff force-pushed the tickets/DM-46356 branch 2 times, most recently from 2a27211 to dc5619d Compare October 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants