DM-42863: Add method to evaluate PTC model in ptcDataset #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Broughton
force-pushed
the
tickets/DM-42863
branch
from
be72ddc
to
26d5620
Compare
Alex-Broughton
force-pushed
the
tickets/DM-42863
branch
from
26d5620
to
123c861
Compare
erykoff
approved these changes
Sep 25, 2024
| self.assertFloatsAlmostEqual(covariancesModel, covModel, atol=1e-13) | ||
| # Note that the PhotoTransferCurveDataset does not store the gain | ||
| # fit parameter for FULLCOVARIANCE with b=0, so we can't compare | ||
| # exactly. |
There was a problem hiding this comment.
Is that something that we need to add?
There was a problem hiding this comment.
Yes we do, but I want to keep this ticket small and then filed this ticket to update the ptc class https://rubinobs.atlassian.net/browse/DM-46509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.