DM-46562: Add bps templates for LSSTCam/LSSTComCam/LATISS calibration creation.

[erykoff]

No description provided.

[czwa]

I think this exclamation point is a typo.

[erykoff]

This is bash "indirection" which should allow one template to be used for all the flats with different selection variables. That's the idea, at least. I haven't gotten to testing this part yet!

[czwa]

This uses selection-string instead of selection_string used elsewhere. Not really a "bug" as this is documentation.

[czwa]

Actual comment: If we have a band variable, we should constrain the query to just that band. This will prevent future accidents where we generate a 15 input g flat and a 1 input r flat in the same collection because an endpoint was misread.

[erykoff]

True but not trivial because we need to know the physical filter in the constraint, so I can't easily template that generally for LATISS/LSSTComCam/LSSTCam. But we can put strong recommendation that SELECTION_FLAT_g and friends include a physical filter constraint!

[czwa]

I don't think we need to know the physical_filter. I assume pipetask and butler query-dimension-records use the same resolver, so something like this should work:

butler query-dimension-records /repo/main exposure --where "instrument='LSSTComCam' AND physical_filter.band='g'" --limit 1
instrument       id      day_obs         group         physical_filter        obs_id        exposure_time    dark_time    observation_type observation_reason seq_num seq_start seq_end target_name science_program tracking_ra tracking_dec sky_angle azimuth zenith_angle has_simulated can_see_sky               timespan (TAI)              
---------- ------------- -------- -------------------- --------------- -------------------- ------------- --------------- ---------------- ------------------ ------- --------- ------- ----------- --------------- ----------- ------------ --------- ------- ------------ ------------- ----------- ------------------------------------------
LSSTComCam 2021040100003 20210401 CALSET_20210401_1601            g_07 CC_O_20210401_000003           1.0 1.5343017578125             flat               flat       3         3       3     UNKNOWN         unknown        None         None      None    None         None         False        None [2021-04-01T16:24:36, 2021-04-01T16:24:37)

[timj]

"instrument='LSSTComCam' AND band='g'" should work and is shorter.

[erykoff]

When getting a flat from a calib repo that doesn't work, so I guess I had assumed we needed it in the constraint as well.

[czwa]

This has a typo as well.

[erykoff]

More bash magic that is supposed to use $SELECTION_PTC_LINEARIZER if it is set and otherwise use $SELECTION_PTC. Also not yet tested if the bps vars support this...

[czwa]

This should also note that selection_string is a dummy variable here, and that it needs to be filled with something explicit. I was going to suggest putting in the information being used on DM-46562 (the ticket used below), but I see that's this ticket adding the BPS templates, not a generation ticket.