-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-38138: Create a build task for remote submission #138
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 78.44% 77.86% -0.58%
==========================================
Files 40 40
Lines 3099 3122 +23
Branches 529 536 +7
==========================================
Hits 2431 2431
- Misses 578 601 +23
Partials 90 90 ☔ View full report in Codecov by Sentry. |
config = BpsConfig(config_file, BPS_SEARCH_ORDER) | ||
_, remote_build = config.search("remoteBuild", opt={"default": {}}) | ||
if remote_build: | ||
if config["wmsServiceClass"] == "lsst.ctrl.bps.panda.PanDAService": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichelleGower Comments? Adding anything to bps that wants to know about a plugin seems wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to look at this yet other than this one line. What @timj says is correct. There shouldn't be a need to write WMS specific code inside ctrl_bps. If we're wanting to do all of the bps submission stages remotely or let's make that more generic to inside a compute job (even a local job), then we should change the bps code generically to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree. At the time when we worked on the remote submission, it's not a generic operation for other WMS, so we tried to keep other WMS intact but only apply the remote submission to PanDA. Basically we need bps has a way to stop generating quantum graph and execution bulter at the stage of transform when it's a remote submission.
87bb2e9
to
14aa1ff
Compare
5c70534
to
70c7e60
Compare
70c7e60
to
89143df
Compare
d1d1f46
to
d9c3465
Compare
Checklist
doc/changes