Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43985: Create bps report API #165

Merged
merged 7 commits into from
Jun 21, 2024
Merged

DM-43985: Create bps report API #165

merged 7 commits into from
Jun 21, 2024

Conversation

mxk62
Copy link
Contributor

@mxk62 mxk62 commented Apr 22, 2024 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@mxk62 mxk62 changed the title Add generic methods for retrieving job summary DM-43985: Create bps report API Apr 22, 2024
@mxk62 mxk62 force-pushed the tickets/DM-43985 branch 2 times, most recently from 9725a20 to d7848d2 Compare April 22, 2024 17:05
@mxk62 mxk62 force-pushed the tickets/DM-43985 branch from d7848d2 to 1a458da Compare May 20, 2024 20:38
@mxk62 mxk62 marked this pull request as ready for review May 20, 2024 20:42
@mxk62 mxk62 requested a review from MichelleGower May 20, 2024 20:42
MichelleGower
MichelleGower approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Merge approved.

python/lsst/ctrl/bps/report.py Show resolved Hide resolved
tests/test_report.py Outdated Show resolved Hide resolved
python/lsst/ctrl/bps/report.py Show resolved Hide resolved
python/lsst/ctrl/bps/report.py Outdated Show resolved Hide resolved
tests/test_report.py Show resolved Hide resolved
mxk62 added 7 commits June 21, 2024 10:17
@mxk62
Add generic methods for retrieving job summary
cf4ab83
@mxk62
Add a new API function for retrieving run reports
b50f515
@mxk62
Add unit tests for compile_job_summary()
fb18035
@mxk62
Add the news item describing the changes
9b83574
@mxk62
Provide a list of default postprocessors
43aa1e3 
Added a list of report postporcessors BPS uses by default.
@mxk62
Add unit tests covering retrieve_report()
d5e654b
@mxk62
Refactor display_report()
83dbd23 
Instead of calling retrieve_report() internally, now display_report()
expects the run reports and/or potential error messages to be passed to
it by the caller.
@mxk62 mxk62 force-pushed the tickets/DM-43985 branch from 1a458da to 83dbd23 Compare June 21, 2024 16:41
@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.61%. Comparing base (fd71243) to head (83dbd23).

Files Patch % Lines
python/lsst/ctrl/bps/report.py 56.75% 15 Missing and 1 partial ⚠️
python/lsst/ctrl/bps/drivers.py 8.33% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   78.30%   78.61%   +0.31%     
==========================================
  Files          40       40              
  Lines        3180     3246      +66     
  Branches      549      558       +9     
==========================================
+ Hits         2490     2552      +62     
- Misses        602      604       +2     
- Partials       88       90       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxk62 mxk62 merged commit edc7f5e into main Jun 21, 2024
13 of 14 checks passed
@mxk62 mxk62 deleted the tickets/DM-43985 branch June 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelleGower MichelleGower MichelleGower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxk62 @MichelleGower