DM-46307: execute butler housekeeping scripts at remote DF for multisite processing #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 60.86% 60.80% -0.06%
==========================================
Files 10 10
Lines 2279 2281 +2
Branches 304 304
==========================================
Hits 1387 1387
- Misses 845 847 +2
Partials 47 47 ☔ View full report in Codecov by Sentry. |
mxk62
force-pushed
the
tickets/DM-46307
branch
from
59ae00d to
133b491
Compare
MichelleGower
approved these changes
Nov 27, 2024
MichelleGower
approved these changes
Nov 28, 2024
mxk62
force-pushed
the
tickets/DM-46307
branch
from
133b491 to
47903de
Compare
_replace_cmd_vars() was expecting `GenericWorfklowJob.cmdvals` to be an empty dictionary if there were no arguments to replace. Setting it to `None` was causing function to raise. Made changes so it can handle this case without raising as well.
mxk62
force-pushed
the
tickets/DM-46307
branch
from
47903de to
81c58b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes