DM-48536: improvements and testing for pipetask report
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 90.17% 90.86% +0.69%
==========================================
Files 50 50
Lines 4631 4686 +55
Branches 426 409 -17
==========================================
+ Hits 4176 4258 +82
+ Misses 325 308 -17
+ Partials 130 120 -10 ☔ View full report in Codecov by Sentry. |
eigerx
approved these changes
Feb 6, 2025
TallJimbo
force-pushed
the
tickets/DM-48536
branch
2 times, most recently
from
1ff8058 to
2ae93ae
Compare
QuantumInfo no longer has 'caveats' key; instead you should get its final run to look at the ceveats on that.
The main quantum and dataset summary tables are unchanged, but the code is now in pipe_base. The JSON-like printouts of data ID information have been replaced with new tables.
TallJimbo
force-pushed
the
tickets/DM-48536
branch
2 times, most recently
from
ee0bdbe to
5cffb1f
Compare
TallJimbo
force-pushed
the
tickets/DM-48536
branch
from
5cffb1f to
cb8ece2
Compare
TallJimbo
force-pushed
the
tickets/DM-48536
branch
from
cb8ece2 to
78a2d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes(inpipe_base)