Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46781: Allow no matching results in a query datasets call on command line #1093

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

timj
Copy link
Member

@timj timj commented Oct 10, 2024

Generally this hasn't been a problem because each matching collection is only querying dataset types where there are non-zero datasets.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Generally this hasn't been a problem because each matching collection
is only querying dataset types where there are non-zero datasets.
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (b419f0f) to head (b0f8f95).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.01%     
==========================================
  Files         361      361              
  Lines       47308    47308              
  Branches     9722     5765    -3957     
==========================================
- Hits        42455    42451       -4     
- Misses       3500     3502       +2     
- Partials     1353     1355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 2dda442 into main Oct 10, 2024
17 of 18 checks passed
@timj timj deleted the tickets/DM-46781 branch October 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants