DM-46599: Deprecate old query system behavior #1096
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
=======================================
Coverage 89.73% 89.74%
=======================================
Files 361 361
Lines 47324 47393 +69
Branches 5709 5723 +14
=======================================
+ Hits 42466 42532 +66
- Misses 3506 3508 +2
- Partials 1352 1353 +1 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-46599
branch
from
5416af4
to
174d6b0
Compare
This was also flagging globs when it shouldn't have been
In the new query system, this functionality can be expressed more clearly using region overlaps.
Collections and dataset type arguments are becoming mandatory, so add them to tests that were using the default 'all' values.
dhirving
force-pushed
the
tickets/DM-46599
branch
from
e77bf87
to
c094e69
Compare
doc/changes/DM-46599.removal.md
Outdated
|
|
||
| The `offset` argument to `limit()` for `Registry.queryDataIds` and `Registry.queryDimensionRecords` result objects is now deprecated. | ||
|
|
||
| The `--offset` option for `butler query-data-ids` and `butler-query-datasets` is now deprecated. |
There was a problem hiding this comment.
It looks like butler query-data-ids raises when --offset is used and query-dimension-records ignores it. Maybe we add a raise to the latter as well? Or remove the raise from the former and add deprecation warnings instead noting that the option is a no-op? I think this happened during the migration to the new query system.
There was a problem hiding this comment.
I didn't realize that these had been switched over to the new query system... theoretically shouldn't have happened until after this deprecation.
Probably better to raise than silently ignore the option, so I'll add an exception to query-dimension-records.
The --offset parameter to query-dimension-records was changed to be silently ignored in DM-45556. It can't be brought back without going back to the old query system. We are removing this entirely soon, and it's better to flag the problem to the user than silently ignore what they asked for. Also added a little more information to a similar information that was being thrown from query-data-ids.
Deprecate behavior from the old query system that will no longer be supported when we switch to the new implementation.
Checklist
doc/changesconfigs/old_dimensions