Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46799: Reapply after revert with bugfix. #1102

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Oct 17, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 86.92185% with 82 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (bde5552) to head (e0205d6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../butler/registry/datasets/byDimensions/_manager.py 86.95% 29 Missing and 28 partials ⚠️
...on/lsst/daf/butler/registry/_dataset_type_cache.py 78.12% 6 Missing and 1 partial ⚠️
...af/butler/registry/datasets/byDimensions/tables.py 89.79% 2 Missing and 3 partials ⚠️
...n/lsst/daf/butler/registry/interfaces/_datasets.py 90.24% 2 Missing and 2 partials ⚠️
python/lsst/daf/butler/registry/sql_registry.py 81.81% 4 Missing ⚠️
.../daf/butler/registry/queries/_sql_query_backend.py 50.00% 3 Missing ⚠️
python/lsst/daf/butler/queries/result_specs.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
- Coverage   89.74%   89.71%   -0.04%     
==========================================
  Files         361      360       -1     
  Lines       47409    47434      +25     
  Branches     5724     5732       +8     
==========================================
+ Hits        42548    42554       +6     
- Misses       3508     3518      +10     
- Partials     1353     1362       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Without this fix, calibration dataset types that were registered in
data repositories where the only existing dataset types with those
dimensions were not calibrations would incorrectly be registered as
non-calibrations.
@TallJimbo TallJimbo merged commit 0ccfb04 into main Oct 18, 2024
16 of 18 checks passed
@TallJimbo TallJimbo deleted the u/jbosch/DM-46799/fixed branch October 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant