Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45087: Remove step8 from HSC/ImSim and move its analysis tasks upstream #135

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

yalsayyad
Copy link
Contributor

Now that we're running RC2/DC2s with the sasquatch butler for all steps, we can move the analysis tasks to the step which creates their input data products.

Move source table consolidation to the global step2 stage, and add consolidateSourceTable to the per-visit sourceTable cluster for [writeRecalibrated|transform|consolidate]SourceTable.

Now that we're running RC2/DC2s with the sasquatch butler for all
steps, we can move the analysis tasks to the step which creates
their input data products.

Move source table consolidation to the global step2 stage, and
add consolidateSourceTable to the per-visit sourceTable cluster
for [writeRecalibrated|transform|consolidate]SourceTable.
Copy link
Contributor

@jtmccann jtmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple comments everything looks good

@@ -92,14 +92,7 @@ tasks:
objectTableCoreRefCatMatchWholeSkyPlot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove all the configs expect "band" for matchedVisitCoreWholeSkyPlot and objectTableCoreWholeSkyPlot

@@ -158,14 +158,7 @@ tasks:
objectTableCoreRefCatMatchWholeSkyPlot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove all the configs expect "band" for matchedVisitCoreWholeSkyPlot and objectTableCoreWholeSkyPlot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also do this in pipelines/HSC/DRP-ci_hsc.yaml

@yalsayyad yalsayyad merged commit 4f72e6c into main Sep 5, 2024
3 checks passed
@yalsayyad yalsayyad deleted the tickets/DM-45087 branch September 5, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants