DM-39168: Add task needed for proper motion in metrics #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
force-pushed
the
tickets/DM-39168
branch
6 times, most recently
from
8541619
to
4ffd507
Compare
parejkoj
reviewed
Aug 13, 2024
pipelines/HSC/DRP-ci_hsc.yaml
Outdated
| analyzeMatchedVisitCore: | ||
| class: lsst.analysis.tools.tasks.AssociatedSourcesTractAnalysisTask | ||
| config: | ||
| applyProperMotions: false |
There was a problem hiding this comment.
Why disable PM correction in HSC? Wouldn't that still improve any metrics that compare with a refcat?
There was a problem hiding this comment.
This is just for ci_hsc, where there's not enough data to run gbdesAstrometricFit. I added comments here and for the other tasks with this config set.
cmsaunders
force-pushed
the
tickets/DM-39168
branch
2 times, most recently
from
dcba5a2
to
037583d
Compare
cmsaunders
force-pushed
the
tickets/DM-39168
branch
from
037583d
to
be497ec
Compare
cmsaunders
force-pushed
the
tickets/DM-39168
branch
from
be497ec
to
97cbcd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.