Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41503: Add selectDeepCoaddVisits to DRP pipelines to select by seeing. #90

Merged
merged 2 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pipelines/HSC/DRP-Prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ subsets:
step3:
subset:
- makeWarp
- selectDeepCoaddVisits
- assembleCoadd
- detection
- mergeDetections
Expand Down
1 change: 1 addition & 0 deletions pipelines/HSC/DRP-RC2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ subsets:
step3:
subset:
- makeWarp
- selectDeepCoaddVisits
- assembleCoadd
- detection
- mergeDetections
Expand Down
1 change: 1 addition & 0 deletions pipelines/HSC/DRP-RC2_subset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ subsets:
nightlyStep3:
subset:
- makeWarp
- selectDeepCoaddVisits
- assembleCoadd
- detection
- mergeDetections
Expand Down
8 changes: 8 additions & 0 deletions pipelines/LATISS/DRP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ tasks:
photo_calib_provider: "global"
background_provider: "input_summary"

selectDeepCoaddVisits:
class: lsst.pipe.tasks.selectImages.BestSeeingSelectVisitsTask
config:
# This is the maximum seeing that can be used with the default 71 pixel
# psf kernel size.
maxPsfFwhm: 1.9

# Importing and defining analyzeObjectTableCore here to omit plots that
# require z and/or y band data.
analyzeObjectTableCore:
Expand Down Expand Up @@ -118,6 +125,7 @@ subsets:
step3a:
subset:
- makeWarp
- selectDeepCoaddVisits
- assembleCoadd
- detection
- mergeDetections
Expand Down
1 change: 1 addition & 0 deletions pipelines/_ingredients/DECam/DRP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ subsets:
step3:
subset:
- selectGoodSeeingVisits
- selectDeepCoaddVisits
- makeWarp
- templateGen
- deblend
Expand Down
11 changes: 11 additions & 0 deletions pipelines/_ingredients/DRP-minimal-calibration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,21 @@ tasks:
class: lsst.pipe.tasks.makeWarp.MakeWarpTask
config:
makePsfMatched: true
selectDeepCoaddVisits:
class: lsst.pipe.tasks.selectImages.BestSeeingSelectVisitsTask
config:
connections.goodVisits: deepCoaddVisits
# Maximum sensible default psf fwhm in arcseconds to use for a coadd
maxPsfFwhm: 2.0
# By default for deep coadds, use all input visits better than maxPsfFwhm
nVisitsMax: -1
assembleCoadd:
class: lsst.drp.tasks.assemble_coadd.CompareWarpAssembleCoaddTask
config:
doInputMap: true
doSelectVisits: true
assembleStaticSkyModel.doSelectVisits: true
connections.selectedVisits: deepCoaddVisits
healSparsePropertyMaps: lsst.pipe.tasks.healSparseMapping.HealSparsePropertyMapTask
consolidateHealSparsePropertyMaps: lsst.pipe.tasks.healSparseMapping.ConsolidateHealSparsePropertyMapTask
detection: lsst.pipe.tasks.multiBand.DetectCoaddSourcesTask
Expand Down
1 change: 1 addition & 0 deletions pipelines/_ingredients/LSSTCam-imSim/DRP.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ subsets:
step3:
subset:
- makeWarp
- selectDeepCoaddVisits
- assembleCoadd
- detection
- mergeDetections
Expand Down
1 change: 1 addition & 0 deletions tests/test_pipelines.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
"calexp",
"calexpBackground",
"ccdVisitTable",
"deepCoaddVisits",
"deepCoadd",
"deepCoadd_calexp",
"deepCoadd_calexp_background",
Expand Down