DM-47919: Add configuration for cutting visits from the fit by PSF FWHM #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the field used for computing empirical depth terms in fgcm from the psfSigma to the psfFwhm and enables cuts on psfFwhm.
laurenam
approved these changes
Dec 6, 2024
| # Compute the median psf sigma and fwhm if possible. | ||
| if 'pixelScale' in summary.schema: | ||
| # This is not available in the older test summaries | ||
| pixelScales = summary['pixelScale'] |
There was a problem hiding this comment.
Awesome that you are using the as-measured pixelScale...it could start to really matter for the full camera!
| keytype=str, | ||
| itemtype=float, | ||
| default={}, | ||
| ) |
There was a problem hiding this comment.
Lovin' the per-band dict ❤️
I don't understand the second sentence...
erykoff
force-pushed
the
tickets/DM-47919
branch
from
70cf000 to
e1aca95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visits that have large PSF FWHM (typically above what is considered for coadds) can now be configured to be calibrated, but skipped in the full model fit. This way bad visits won't bias the fit for the good visits, and there is less outlier rejection work. Default config is not to do any cutting at all. Note that this can be configured per-band to future proof in case we decide to go that route in our coadd selection.
When converting from psfSigma to psfFwhm the camera average pixel scale is used if the input visit tables do not have
pixelScale. This is only relevant for the old test data intestdata_jointcal.