Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42714: Convert to new workload identity setup #496

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented Mar 1, 2024

Use google_service_account_iam_member instead of
google_service_account_iam_binding to set up workload identity. Narrow the grant of bindings for the vault and git-lfs service accounts to just the Google service accounts they should be using.

Use google_service_account_iam_member instead of
google_service_account_iam_binding to set up workload identity.
Narrow the grant of bindings for the vault and git-lfs service
accounts to just the Google service accounts they should be using.
Copy link
Contributor

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So what I was fundamentally missing was the service_account_id to force binding of the WI member to one and only one service account.

@rra rra merged commit e86a512 into main Mar 4, 2024
4 checks passed
@rra rra deleted the tickets/DM-42714 branch March 4, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants