Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore Directory Provisioning Region Fix #510

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Firestore Directory Provisioning Region Fix #510

merged 1 commit into from
Apr 16, 2024

Conversation

dspeck1
Copy link
Collaborator

@dspeck1 dspeck1 commented Apr 16, 2024

Fix region value as it was referencing value that was not defined.

athornton
athornton approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the general case, I'd make this another user input required parameter with a default of "us-central1" in case we want to go somewhere else, but for right now, sure.

@dspeck1 dspeck1 merged commit 3e6da79 into main Apr 16, 2024
1 check passed
@dspeck1 dspeck1 deleted the u/dspeck/firestore-auth-fix-region branch April 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athornton athornton athornton approved these changes

Assignees

@athornton athornton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dspeck1 @athornton