Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43077: Convert all tasks to use CalibrateImageTask outputs #285

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

DM-43077: Convert all tasks to use CalibrateImageTask outputs #285

wants to merge 4 commits into from

Conversation

parejkoj
Copy link
Contributor

No description provided.

@parejkoj
Switch to calibrateImage outputs
a9d2347
@parejkoj
Remove STREAK pixel flag propagation
3ee5de9 
initial_pvi does not have STREAK; we probably should change this task
to run on the final `pvi` dataset, which is fully calibrated and with
the best PSF. It will (eventually) have the STREAK propagated from the
diffim, where it should come from (not this single frame output).
@TallJimbo
Make visit summary usage optional in ForcedPhotCcd.
308b7ae
@TallJimbo
Use 'pvi', not 'initial_pvi', in forcedPhotCcd.
80fcb17 
We also turn off using the finalVisitSummary input, which is important
for the PhotoCalib, since both pvi and initial_pvi have their pixel
values calibrated to nJy and their PhotoCalib reset to the identity.
This means forcedPhotCcd's instFlux columns will actually have nJy
units, but this is fine since their "DN" is already an arbitrary unit
and the LocalPhotoCalib column will reflect this by being full of ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeskelvin leeskelvin leeskelvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parejkoj @leeskelvin @TallJimbo