Skip to content

Commit

Permalink
Merge pull request #473 from lsst/tickets/DM-41846
Browse files Browse the repository at this point in the history
DM-41846: Use the test ID as the unique component of the test run collection
  • Loading branch information
timj authored Nov 27, 2023
2 parents 992db00 + bda3b08 commit c5b8ef7
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repos:
- id: trailing-whitespace
- id: check-toml
- repo: https://github.com/psf/black
rev: 23.10.1
rev: 23.11.0
hooks:
- id: black
# It is recommended to specify the latest version of Python
Expand All @@ -22,6 +22,6 @@ repos:
name: isort (python)
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.1.2
rev: v0.1.6
hooks:
- id: ruff
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

[tool.black]
line-length = 110
target-version = ["py310"]
target-version = ["py311"]

[tool.isort]
profile = "black"
Expand Down Expand Up @@ -77,7 +77,7 @@ select = [
"W", # pycodestyle
"D", # pydocstyle
]
target-version = "py310"
target-version = "py311"
extend-select = [
"RUF100", # Warn about unused noqa
]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_butlerFits.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def tearDownClass(cls):
shutil.rmtree(cls.root, ignore_errors=True)

def setUp(self):
self.butler = makeTestCollection(self.creatorButler)
self.butler = makeTestCollection(self.creatorButler, uniqueId=self.id())

def makeExampleCatalog(self) -> lsst.afw.table.SourceCatalog:
catalogPath = os.path.join(TESTDIR, "data", "source_catalog.fits")
Expand Down
2 changes: 1 addition & 1 deletion tests/test_defineVisits.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def setUp(self):
"""
self.root = tempfile.mkdtemp(dir=TESTDIR)
self.creatorButler = butlerTests.makeTestRepo(self.root, [])
self.butler = butlerTests.makeTestCollection(self.creatorButler)
self.butler = butlerTests.makeTestCollection(self.creatorButler, uniqueId=self.id())

self.config = DefineVisitsTask.ConfigClass()
self.task = DefineVisitsTask(config=self.config, butler=self.butler)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_ingest.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def tearDownClass(cls):
shutil.rmtree(cls.root, ignore_errors=True)

def setUp(self):
self.butler = butlerTests.makeTestCollection(self.creatorButler)
self.butler = butlerTests.makeTestCollection(self.creatorButler, uniqueId=self.id())
self.outputRun = self.butler.run

config = RawIngestTask.ConfigClass()
Expand Down Expand Up @@ -433,7 +433,7 @@ def tearDownClass(cls):
shutil.rmtree(cls.root, ignore_errors=True)

def setUp(self):
self.butler = butlerTests.makeTestCollection(self.creatorButler)
self.butler = butlerTests.makeTestCollection(self.creatorButler, uniqueId=self.id())

self.config = RawIngestTask.ConfigClass()
self.config.transfer = "copy" # safe non-default value
Expand Down

0 comments on commit c5b8ef7

Please sign in to comment.