DM-26658: Migrate to V2 formatter #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-26658
branch
2 times, most recently
from
059bb7a
to
efc2965
Compare
TallJimbo
approved these changes
Jul 5, 2024
| @@ -369,7 +360,9 @@ def observationInfo(self): | |||
| read-only). | |||
| """ | |||
| if self._observationInfo is None: | |||
| location = self.fileDescriptor.location | |||
| # Use the primary path rather than any local variant that the | |||
| # formatter might be using. | |||
There was a problem hiding this comment.
What kind of "local variant" might be in play here?
timj
force-pushed
the
tickets/DM-26658
branch
4 times, most recently
from
bbbf5d8
to
d50f0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes