DM-29761: start saving per-quantum provenance and propagating nothing-to-do cases #183
Conversation
Everything else in a PipelineTask implementation already worked with connection names, not dataset type names. WIP: remove the optional return stuff from this and put it on a separate commit.
This will allow code in ctrl_mpexec to delegate to adjustQuantum before calling runQuantum, to test whether running is necessary in the exact same way it is tested at QG generation time.
TallJimbo
force-pushed
the
tickets/DM-29761
branch
from
97996dc to
af16b87
Compare
| @@ -547,6 +547,24 @@ def translateAdjustQuantumInputs( | |||
| ) | |||
| return results | |||
|
|
|||
| def hasPostWriteLogic(self): | |||
There was a problem hiding this comment.
🤷♂️ , I just never know what to do with boolean flag getters; I feel like "starts with verb" implies "it's a method", but there's pretty much no other way to name boolean properties. I'm not even consistent about that within this commit.
Everybody else in the world, please just agree on what we should do in this case and I'll happily follow along.
There was a problem hiding this comment.
Is the implied rest of the question "and not a property"?
There was a problem hiding this comment.
Or just an attribute, That's the great thing about properties is that they can be migrated or substituted in place of an attribute if needed
There was a problem hiding this comment.
This one shouldn't be an attribute, because I think the right specialization pattern is "override method [or property]".
There was a problem hiding this comment.
Why is that better than setting a class level attribute? I really don't understand why this is such an uncommon thing. Are you trying to protect it from changing, and if so other code would be needed here.
No description provided.