Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41345: Make dimension packer config optional #381

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Oct 26, 2023

The default config should work in most cases, so it doesn't need to be required.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (facbe7f) 82.46% compared to head (63641dd) 82.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   82.46%   82.43%   -0.04%     
==========================================
  Files          92       92              
  Lines       10352    10354       +2     
  Branches     1951     1952       +1     
==========================================
- Hits         8537     8535       -2     
- Misses       1473     1475       +2     
- Partials      342      344       +2     
Files Coverage Δ
...on/lsst/pipe/base/_observation_dimension_packer.py 92.15% <0.00%> (-3.77%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The default config should work in most cases, so it doesn't need to be
required.
@parejkoj parejkoj merged commit e1ab719 into main Nov 2, 2023
12 of 14 checks passed
@parejkoj parejkoj deleted the tickets/DM-41345 branch November 2, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants