Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43572: Input connection with deferred binding #410

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

tgoldina
Copy link
Contributor

@tgoldina tgoldina commented Mar 28, 2024

These are minimal changes to make an input connection with deferred binding, which would allow us to have an input connection with the same dataset type as an output. (The input would have a different dataset reference than the output.)

This is the first step in creating a Quantum Graph, which would process images with persistence. In this use case, the images must be processed in order, each QuantumNode takes prior persistence state and produces its own.

This replaces #407

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

… to have the same dataset type as an output.
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.40%. Comparing base (697e81c) to head (17eb63f).

Files Patch % Lines
python/lsst/pipe/base/connections.py 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   82.40%   82.40%   -0.01%     
==========================================
  Files          93       93              
  Lines       10661    10660       -1     
  Branches     2022     2020       -2     
==========================================
- Hits         8785     8784       -1     
  Misses       1522     1522              
  Partials      354      354              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj requested a review from TallJimbo March 28, 2024 19:18
@timj
Copy link
Member

timj commented Mar 28, 2024

The mypy problem is caused by a change in daf_butler. I'm fixing it in lsst/daf_butler#986 and the mypy check can be rerun once that merges.

@tgoldina tgoldina merged commit 3034863 into main Mar 29, 2024
11 of 13 checks passed
@tgoldina tgoldina deleted the tickets/DM-43572 branch March 29, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants