-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41605: Command-line aggregator for pipetask report #437
Conversation
392b330
to
96c40bd
Compare
aadfd5f
to
e3a5cc4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 83.22% 83.21% -0.01%
==========================================
Files 99 99
Lines 11861 12078 +217
Branches 1485 1524 +39
==========================================
+ Hits 9871 10051 +180
- Misses 1604 1621 +17
- Partials 386 406 +20 ☔ View full report in Codecov by Sentry. |
02a2a82
to
08bf168
Compare
The mypy error I'm getting here doesn't seem to be about my additions to the codebase. Can someone point me to what to do about issues with |
06126e1
to
751d870
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but consider a more descriptive variable like other_summary
or the like.
@@ -485,6 +485,24 @@ def add_quantum_info(self, info: QuantumInfo, butler: Butler, do_store_logs: boo | |||
case unrecognized_state: | |||
raise AssertionError(f"Unrecognized quantum status {unrecognized_state!r}") | |||
|
|||
def add_data_id_group(self, other: TaskSummary) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a more descriptive variable than other here?
751d870
to
0639af2
Compare
Checklist
doc/changes