Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48333: Update UnprocessableDataError to inherit from NoWorkFound #461

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

laurenam
Copy link
Contributor

@laurenam laurenam commented Jan 8, 2025

This is so that the job will not be considered a failure, thus precluding any inadvertent human time being spent chasing up the failure.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This is so that the job will not be considered a failure, thus
precluding any inadvertent human time being spent chasing up
the failure.
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (cd2e615) to head (05814d2).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ython/lsst/pipe/base/tests/mocks/_storage_class.py 0.00% 2 Missing ⚠️
python/lsst/pipe/base/_task_metadata.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   83.22%   83.20%   -0.02%     
==========================================
  Files         103      103              
  Lines       12227    12227              
  Branches     1546     1546              
==========================================
- Hits        10176    10174       -2     
- Misses       1641     1642       +1     
- Partials      410      411       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurenam laurenam requested a review from TallJimbo January 8, 2025 19:56
This may well be a MyPy bug; certainly IMO more checking on function
signatures that are already full of typing.Any is not an improvement.
@laurenam laurenam merged commit 9865311 into main Jan 9, 2025
12 of 14 checks passed
@laurenam laurenam deleted the tickets/DM-48333 branch January 9, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants