Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47730: Use new refcat loader method to improve refcat flux field checks. #1024

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

TallJimbo
Copy link
Member

The new implementation no longer assumes there is a refcat shard overlapping the center of a tract, which was important for ci_hsc.

@jrmullaney jrmullaney self-requested a review January 17, 2025 17:00
Copy link
Contributor

@jrmullaney jrmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm just curious aboout something in the test suite.

tests/test_loadReferenceCatalog.py Show resolved Hide resolved
The new implementation no longer assumes there is a refcat shard
overlapping the center of a tract, which was important for ci_hsc.
@TallJimbo TallJimbo merged commit 6b5a48f into main Jan 21, 2025
2 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47730 branch January 21, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants