-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-41291: Migrate the Qserv control plane protocol to HTTP #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iagaponenko
force-pushed
the
tickets/DM-41291
branch
4 times, most recently
from
November 30, 2023 06:24
55a1b2b
to
0230c64
Compare
jgates108
reviewed
Dec 4, 2023
jgates108
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only minor comments. I don't fully understand what happens when there are failures during communication, or the intricacies of the communications, but everything looks reasonable and the changes look like improvements to me.
The function is missing in the C++ Standard Library.
A new set of parameters includes those needed for registering workers in the Replication System's Registry as well as parameters of the management service itself.
Added REST services dedicated to Qserv workers.
The new API allows a client to wait for completion of a request. This would only block a client thread from which the request completion operation is called. This doesn't affect request processing that will still be one in the asynchronous mode.
The change reduces code duplication in implementations of the HTTP services outside the Replication Sytem's codebase.
The server is meant to process management and monitoring requests sent by the Replication Controller and relevant applications.
Refactored worker XROOTD/SSI resource monitoring by moving class from to module wpublish to wcontrol. An object of the class is now owned by class Foreman which is AKA "service provider" for the Qserv worker. Shifted the chunk inventory collection from SsiService into Foreman for better and more convenient dependency management. The second reason of the change was to prepare ground for implementing HTTP-based worker management services.
The extended API has an option for dynamic updates of the connection parameters for the remote Web server. This allows tracking changes in a location of the server as needed by an application context. Refactored and extended the unit test for AsyncReq.
Extended worker descriptor to include parameteres of the Qserv worker management service.
The new design of the Qserv managememt control plain now relies upon the HTTP protocol to communicate with workers.
The new version has a better layout. It also shows more information, including IP addresses of service hosts and parameters of the HTTP-based Qserv worker management services.
iagaponenko
force-pushed
the
tickets/DM-41291
branch
from
December 7, 2023 00:35
f29252b
to
4cb58b7
Compare
iagaponenko
changed the title
Tickets/dm 41291
DM-41291: Migrate the Qserv control plane protocol to HTTP
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.