DM-47612: Refactoring and simplifications in the Qserv worker replication service #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgates108
approved these changes
Nov 19, 2024
| @@ -86,55 +80,20 @@ class WorkerDeleteRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseDelete& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute() override; | |||
There was a problem hiding this comment.
This should just be override without virtual as the base class WorkerRequest has virtual bool execute() defined.
C++ style guide 5-44
| * @param response Protobuf response to be initialized | ||
| */ | ||
| void setInfo(ProtocolResponseDirectorIndex& response) const; | ||
|
|
||
| bool execute() override; | ||
| virtual bool execute(); |
There was a problem hiding this comment.
Shouldn't this be override instead of virtual as execute() is declared virtual in WorkerRequest?
| @@ -83,27 +80,20 @@ class WorkerEchoRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseEcho& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute(); | |||
There was a problem hiding this comment.
Shouldn't this should be override instead of virtual?
| @@ -83,56 +78,20 @@ class WorkerFindAllRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseFindAll& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute(); | |||
There was a problem hiding this comment.
Shouldn't it be override?
| @@ -91,59 +84,23 @@ class WorkerFindRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseFind& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute(); | |||
There was a problem hiding this comment.
Shouldn't it be override?
| @@ -102,86 +98,13 @@ class WorkerReplicationRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseReplicate& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute(); | |||
There was a problem hiding this comment.
Shouldn't it be override?
| @@ -92,7 +92,7 @@ class WorkerSqlRequest : public WorkerRequest { | |||
| */ | |||
| void setInfo(ProtocolResponseSql& response) const; | |||
|
|
|||
| bool execute() override; | |||
| virtual bool execute(); | |||
There was a problem hiding this comment.
Shouldn't it be override?
iagaponenko
force-pushed
the
tickets/DM-47612
branch
from
562ed4f to
bc83e54
Compare
iagaponenko
force-pushed
the
tickets/DM-47612
branch
from
bc83e54 to
602123d
Compare
The parameter is no longer needed after refacttoring and simplifying a design and implementation of the worker service. Also cleaned empty lines in the worker code
iagaponenko
force-pushed
the
tickets/DM-47612
branch
from
602123d to
e42b22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.