Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1157: Add ObservationsArray - change observations to proper numpy subclass #102

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Sep 13, 2024

Make ObservationArray and ScheduledObservationArray subclasses of numpy arrays. Also dropping JSON_Block from the schema.

Quick test shows there's no performance hit making the change. Previous convienince functions updated to be backwards compatible and throw a warning.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (bb86895) to head (d15c6c5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
rubin_scheduler/scheduler/utils/utils.py 72.22% 5 Missing ⚠️
rubin_scheduler/scheduler/surveys/dd_surveys.py 33.33% 2 Missing ⚠️
tests/scheduler/test_example.py 90.00% 1 Missing and 1 partial ⚠️
rubin_scheduler/scheduler/features/features.py 50.00% 1 Missing ⚠️
rubin_scheduler/scheduler/sim_runner.py 66.66% 1 Missing ⚠️
rubin_scheduler/scheduler/surveys/base_survey.py 0.00% 1 Missing ⚠️
rubin_scheduler/scheduler/surveys/desc_ddf.py 50.00% 1 Missing ⚠️
...cheduler/scheduler/surveys/too_scripted_surveys.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   72.87%   72.85%   -0.03%     
==========================================
  Files         143      144       +1     
  Lines       15084    15098      +14     
  Branches     2062     2063       +1     
==========================================
+ Hits        10993    10999       +6     
- Misses       3639     3645       +6     
- Partials      452      454       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yoachim yoachim merged commit 3a77715 into main Sep 13, 2024
8 of 9 checks passed
@rhiannonlynne rhiannonlynne changed the title Tickets/opsim 1157: Change observations to proper numpy subclass OPSIM-1157: Add ObservationsArray - change observations to proper numpy subclass Sep 14, 2024
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1157 branch September 16, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants