OPSIM-1196: more cleanup for summit use #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
force-pushed
the
tickets/OPSIM-1196
branch
from
a4f8753
to
dafbd95
Compare
|
Also adds add_observation_array for some features which didn't have this previously, adds "scheduler_note" and "filter" options to LastObservation. Also makes the BaseFeature class an Abstract class, to enforce having both add_observation and add_observation_array methods on new features. |
|
Unit tests are failing because mambaforge has to be changed to miniforge in the workflow scripts .. and there's a separate PR, so when that is merged I can rebase and this should work. |
rhiannonlynne
force-pushed
the
tickets/OPSIM-1196
branch
from
b8f1807
to
5c888c9
Compare
…est more options for LastObservation.
rhiannonlynne
force-pushed
the
tickets/OPSIM-1196
branch
from
5c888c9
to
bb0bf91
Compare
yoachim
requested changes
Oct 2, 2024
yoachim
approved these changes
Oct 3, 2024
In the end, I did find a potential solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines tel_alt_limits and tel_az_limits as the kinematic / observatory model limits for alt and az.
Defines sky_alt_limits and sky_az_limits as the on-sky (potentially disjoint) limits for alt and az.
Remove empty_observation and scheduler_observation completely.
Remove unused kwargs for FieldSurvey (reward_value and nexp).