-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSIM-1093: feature. Migration from rubin_sim. #5
Conversation
There are a few files here still importing from rubin_sim, which needs either updates or moving or deleting. scheduler/detailers/vary_exptime may be problematic (?) |
It would be awesome if there was a way to more easily see what changed or not between the rubin_sim contents and the contents that moved here, but it seems like it's hanging together. A test example of the scheduler output between the two versions would be nice to confirm, not sure if you had other ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are just a few more things to clean up, but this looks pretty good!
rubin_scheduler/scheduler/model_observatory/model_observatory.py
Outdated
Show resolved
Hide resolved
89df3b8
to
7b066f7
Compare
7b066f7
to
4561c31
Compare
@@ -3,12 +3,16 @@ | |||
|
|||
import astropy.units as u | |||
import numpy as np | |||
|
|||
# Technically this script should be over in rubin_sim, but here to be more | |||
# easily found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to leave a test in rubin_sim?
I can’t tell if having this here will lead to problems with for example building docs, because rubin_sim won’t be available, but I guess we can try to solve that if it comes up. I agree that it’s nice to have it bundled here with the actual scheduler.
Big migration of code from
rubin_sim
torubin_scheduler
includingdata
,scheduler
,site_models
,skybrightness_pre
, andutils
along with relevant unit tests.Several things from
utils
were deprecated (ObservationMetadata
,time_handler
, etc).Dependencies on
palpy
were removed and coordinate conversions were swapped to useastropy
.The
zernike
tools inskybrightness_pre
were not migrated as they had lots ofpalpy
calls and unit tests that depended on outdated skybrightness files. It can be migrated later if wanted.