Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1175: update the kinematic model and altazshadowmask basis function #88

Merged
merged 20 commits into from
Sep 11, 2024

Commits on Sep 7, 2024

  1. Modify AltAzShadowMask to allow azimuth keyword arguments, not just c…

    …onditions objects. Now will use most restrictive of either keyword or conditions values (so default conditions are widely set).
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    d44ddad View commit details
    Browse the repository at this point in the history
  2. Modify kinematic model to calculate slews with azimuth limits < 360.

    Modify use of filters within kinematic model (slewtime can be calculated in any filter, filter will be set to one of allowable filters when parked).
    Conditions object gets azimuth limits from azimuth limits of model.
    AltAzShadowMaskBasisFunction adds padding for azimuth limits from telescope model.
    RotSkyPos values out of range are only masked in the parts of the sky where they are out of range.
    Add dictionary of tma/rotator values that can be set via “percent of max performance”.
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    fe75fc4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1842a11 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a246779 View commit details
    Browse the repository at this point in the history
  5. Black and isort

    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e7e1fde View commit details
    Browse the repository at this point in the history
  6. Clean up unit test after merge conflicts (+1 squashed commit)

    Squashed commits:
    [4611e38] Update unit test parameters and error message, plus comments
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    dd60987 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4151684 View commit details
    Browse the repository at this point in the history
  8. Mark alternative zenith or azimuth masks as to be deprecated.

    isort (+1 squashed commit)
    Squashed commits:
    [dd539c5] Mark alternative zenith or azimuth masks as to be deprecated.
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    afbf932 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    157d642 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    280eb3d View commit details
    Browse the repository at this point in the history
  11. Rework AltAzShadowMaskBasisFunction

    Keeps previous capability of allowing disjoint altitude or azimuth regions, while also respecting kinematic model constraints
    Added more extensive unit test
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    ade3439 View commit details
    Browse the repository at this point in the history
  12. black and isort

    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a24c7fe View commit details
    Browse the repository at this point in the history
  13. Provide correct inputs to AltAzShadowMask basis function, and make it…

    … more robust against similar issues.
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    bb3f768 View commit details
    Browse the repository at this point in the history
  14. Move the comcam DDF centers to the current ddf_locations, but hard-co…

    …de them.
    
    Keith expects to modify this over the course of commissioning, and that the field centers may not align with full LSSTCam field centers anyway, so hard-coded is likely easier to see and track.
    rhiannonlynne committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    6fb5037 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f3a22b1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9ce56ef View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4e891a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    7f83987 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9731ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c7e325 View commit details
    Browse the repository at this point in the history