Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1184: use ra/dec to order series of observations in BlobSurvey #95

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Sep 6, 2024

Eliminate an unnecessary ra,dec to alt,az conversion. Was probably originally stuck in there at some point because of a degrees,radians issue downstream.

Copy link
Collaborator

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, as far as I can tell. A test to verify that the change doesn't change the resultant order for some sample sets of observations would be reassuring.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.09%. Comparing base (71cbc4a) to head (30ce4e6).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   72.89%   72.09%   -0.81%     
==========================================
  Files         137      143       +6     
  Lines       13583    14891    +1308     
  Branches     1870     2061     +191     
==========================================
+ Hits         9902    10736     +834     
- Misses       3269     3722     +453     
- Partials      412      433      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoachim yoachim merged commit 28f62a8 into main Sep 6, 2024
8 of 9 checks passed
@rhiannonlynne rhiannonlynne changed the title tickets/OPSIM-1184: use ra/dec to order OPSIM-1184: use ra/dec to order series of observations in BlobSurvey Sep 11, 2024
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1184 branch September 11, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants