Skip to content

Commit

Permalink
Merge pull request #287 from lsst/tickets/DM-47844
Browse files Browse the repository at this point in the history
DM-47844: Add workflow that runs extra validation checks
  • Loading branch information
JeremyMcCormick authored Dec 10, 2024
2 parents 450babd + 661a956 commit 43bd5d1
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 135 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/validate.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Validate SDM schemas using Felis
name: Validate Schemas

on: [push, workflow_dispatch]

Expand All @@ -8,18 +8,10 @@ jobs:

steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.12"
cache: "pip"

- name: Install dependencies
run: |
python -m pip install --upgrade pip uv
uv pip install --system -r requirements.txt
- name: Setup Python and install dependencies
uses: ./.github/actions/setup-test-environment

- name: Validate YAML files
run: felis validate --check-redundant-datatypes ./yml/*.yaml
24 changes: 24 additions & 0 deletions .github/workflows/validate_extra_checks.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Validate Schemas with Extra Checks

on:
workflow_dispatch:

jobs:
validate-extra-checks:
runs-on: ubuntu-latest

steps:
- name: Check out repo
uses: actions/checkout@v4

- name: Setup Python and install dependencies
uses: ./.github/actions/setup-test-environment

- name: Validate YAML files with extra checks
run: |
felis validate \
--check-description \
--check-redundant-datatypes \
--check-tap-table-indexes \
--check-tap-principal \
./yml/*.yaml
29 changes: 0 additions & 29 deletions .github/workflows/validator.yaml

This file was deleted.

94 changes: 0 additions & 94 deletions tap-schema/validator

This file was deleted.

0 comments on commit 43bd5d1

Please sign in to comment.