DM-44884: Remove DP0.1 from TAP_SCHEMA build & DataLink #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-44884
branch
from
b7771d7 to
e394e82
Compare
stvoutsin
force-pushed
the
tickets/DM-44884
branch
2 times, most recently
from
2a56696 to
776e100
Compare
gpdf
force-pushed
the
tickets/DM-44884
branch
from
776e100 to
f739096
Compare
|
I have updated the PR to reflect the initial removal of DP0.1 from idfdev and idfint, done on #250 . That PR avoid current validation errors due to the previous deletion of the DP0.1 data from the backing Qserv for dev/int. |
|
Approval of this PR will be contingent on approval of DM-46163, "Remove DP0.1 catalogs from public RSP". |
gpdf
changed the title
JeremyMcCormick
force-pushed
the
tickets/DM-44884
branch
from
f739096 to
ae9d611
Compare
gpdf
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
@frossie has approved the removal of DP0.1 from idf-prod, and the DP0 delegates have long since been warned that this was coming. See https://rubinobs.atlassian.net/browse/DM-46163 .
This change is approved for deployment.
Preserves the schema in the archive subdirectory for reference. Removes all DataLink configuration associated with DP0.1.
JeremyMcCormick
force-pushed
the
tickets/DM-44884
branch
from
ae9d611 to
e08abe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Removes DP0.1 from the TAP_SCHEMA build for idfprod and removes all associated DataLink support.
Jira issue:
https://rubinobs.atlassian.net/browse/DM-44884
Description:
The current TAP_SCHEMA image expects to find the DP0.1 catalog & tables. While Qserv for idfprod still has this dataset, we plan to remove it imminently, so removing it from TAP_SCHEMA first allows the Qserv team to take the actual data down later at their discretion without worrying about producing a non-valid service. I've removed them from the build-all script, but I haven't removed the actual yaml metadata files, in case they are needed in the future.
Update: Changed to use ticket as branch name & modified datalink directory to remove dp01 there as well. I've removed the columns-minimal.yaml as well, let me know if this is incorrect.