DM-44878: Change build engine to mysql and set values for size on TAP_SCHEMA columns #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on a fix to https://rubinobs.atlassian.net/browse/DM-45139 |
JeremyMcCormick
requested changes
Jul 8, 2024
JeremyMcCormick
changed the title
stvoutsin
force-pushed
the
tickets/DM-44878
branch
from
a799575 to
89ea2a9
Compare
JeremyMcCormick
changed the title
JeremyMcCormick
changed the title
gpdf
approved these changes
Aug 5, 2024
JeremyMcCormick
force-pushed
the
tickets/DM-44878
branch
from
89ea2a9 to
1bb3a1b
Compare
JeremyMcCormick
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add size value to the TAP_SCHEMA column entries that get inserted. This addresses the issue where validators expect the "size" column to match the "arraysize" col.
The second change is to modify the engine-url to "mysql", as the TAP_SCHEMA database currently deployed is in MySQL, so the insert statements need to be produced for that as far as I can see. I noticed this after trying to add values for the size column, which produced invalid SQL statements.
How was this tested