Skip to content

Commit

Permalink
Fix expected df in TestMetricSummary's test_compute (facebook#3381)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#3381

Our nightly cron GHA has recently started failing due to a unit test (https://github.com/facebook/Ax/actions/workflows/cron.yml)

WIth the changes introduced in D69611291, we now set `lower_is_better` on objective metrics in configure_optimization() - this change is to update the `test_compute` unit test to reflect this

Reviewed By: mpolson64

Differential Revision: D69786858

fbshipit-source-id: ec57df85a0171ddf121d095910bd7bffb1c902c9
  • Loading branch information
paschai authored and facebook-github-bot committed Feb 18, 2025
1 parent 45b04b6 commit 185cea1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ax/analysis/tests/test_metric_summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_compute(self) -> None:
),
),
"Bound": ["None", ">= 1.0", "<= 0.0", "None"],
"Lower is Better": ["None", "None", "None", "None"],
"Lower is Better": [False, False, "None", "None"],
}
)
pd.testing.assert_frame_equal(card.df, expected)

0 comments on commit 185cea1

Please sign in to comment.