[Squash] Add paramtype2 colorflowingliquid

[DragonWrangler1]

Closes #12897.

this is an adoption of #12907

• colorflowingliquid has been added.
• The upper four bits of flowing liquid nodes are not cleared by liquid transformation.
• post_effect_use_node_color has been added, which lets the post effect color vary depending on a node's param2 color.

To do

This PR is Ready for Review.

• Are nodes colored correctly when using post_effect_use_node_color? It was copied from the procedure of the [multiply texture modifier.

How to test

1. Try the new liquid whose source node is testnodes:colorflowingliquid_source. Try changing the color of some flowing liquid using the param2 tool. Make sure the post effect color varies with the palette index. (has up to 16 colors)
2. Test the liquid color and post effect color on an old client.
3. Try connecting to an old server with a new client.
4. Make sure liquid flow still works.

[grorp]

Attribution to the original author needs to be preserved in Git history.

[DragonWrangler1]

@grorp And how do I do that ? I'm working on a totally different branch, in a totally different repo, and a totally different version.

[rollerozxa]

@grorp And how do I do that ? I'm working on a totally different branch, in a totally different repo, and a totally different version.

Add them as a co-author in commits. When a PR is squashed any commit should work to make them be attributed in the squashed merged commit.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

[DragonWrangler1]

@rollerozxa Thanks.

[corarona]

you can also put any author you want to using git commit --author="Author <[email protected]>"

[Wbjitscool]

while liquid is being worked on I was just wondering if it is possible to adjust the liquid node heights too like in a setting or something?

[DragonWrangler1]

while liquid is being worked on I was just wondering if it is possible to adjust the liquid node heights too like in a setting or something?

It is possible, but I won’t be doing that in this pr.

[Wbjitscool]

okay

[appgurueu]

Are nodes colored correctly when using post_effect_use_node_color? It was copied from the procedure of the [multiply texture modifier.

Seems sensible to me, the shaders just do a RGB multiplication for hardware coloring as well.

---

A question: What would / should happen if a node is "flowed into" by two neighboring flowing liquids of the same type but different colors?

[DragonWrangler1]

Apologies for the delay. I’ll resume work on this shortly. Had some irl work to do, before spending too much time on this.

[DragonWrangler1]

Are nodes colored correctly when using post_effect_use_node_color? It was copied from the procedure of the [multiply texture modifier.

Seems sensible to me, the shaders just do a RGB multiplication for hardware coloring as well.

A question: What would / should happen if a node is "flowed into" by two neighboring flowing liquids of the same type but different colors?

Should randomly pick one of the colors.