Enable support for internal jdk #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dk version 22-internal 2024-03-19
|
I am not sure if this is the right place. I am copying from time to time that script from https://github.com/dwijnand/sbt-extras/blob/master/sbt . I think it should be fixed there as I will forget about that patch and overwrite it. |
|
Hi Luben, Thanks for the information! |
|
I updated the sbt script and patched it to support internal builds. Let's hope I don't forget the next time. |
|
Thanks @luben ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
( I'm new to zstd-jni, please kindly let me know if I need to follow some process for this pr. )
Can I have a review of this simple patch? It enables support for internal jdk, which has version string like: openjdk version 22-internal 2024-03-19. It helps during the development of jdk.
Thanks!