Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netcoreapp projects for Linux #131

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

dstroup
Copy link
Contributor

@dstroup dstroup commented Apr 25, 2019

This should get the netcoreapp2.0 projects building again, and running on Linux. I've only tested this building with Visual Studio 2017 and running on Windows 10 (WGL) & Ubuntu 18.04 (GLX).

On Ubuntu, I had to create the symlink /usr/lib/x86_64-linux-gnu/libX11.so -> /usr/lib/x86_64-linux-gnu/libX11.so.6 in addition to these changes. This isn't required under Mono because Mono supports DLLMap. While .NET Core doesn't support DLLMap, Core 3.0 is adding similar functionality.

Project file changes were copied from pull request #101 to fix issues with the use of BaseIntermediateOutputPath in order to get the project files to load properly.

I added #defines around the dlopen DllImports to account for marshaling differences, as noted in issue #107.

Finally, I removed the #define around the version info in AssemblyInfo.cs. This was causing assembly load errors because the assembly had an incorrect version (0.0.0.0).

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          91       91           
  Lines       27663    27663           
  Branches     1938     1938           
=======================================
  Hits        25490    25490           
  Misses       1926     1926           
  Partials      247      247
Flag Coverage Δ
#WGL_net35_x64_Release 92.22% <ø> (ø) ⬆️
#WGL_net35_x86_Release 90.97% <ø> (ø) ⬆️
#WGL_net461_x64_Release 91.59% <ø> (ø) ⬆️
#WGL_net461_x86_Release 90.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
Khronos.Net/GetProcAddressOS.cs 40% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b954a5...a3667bf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          91       91           
  Lines       27663    27663           
  Branches     1938     1938           
=======================================
  Hits        25490    25490           
  Misses       1926     1926           
  Partials      247      247
Flag Coverage Δ
#WGL_net35_x64_Release 92.22% <ø> (ø) ⬆️
#WGL_net35_x86_Release 90.97% <ø> (ø) ⬆️
#WGL_net461_x64_Release 91.59% <ø> (ø) ⬆️
#WGL_net461_x86_Release 90.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
Khronos.Net/GetProcAddressOS.cs 40% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b954a5...a3667bf. Read the comment docs.

@luca-piccioni luca-piccioni merged commit e435558 into luca-piccioni:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants