fix some cppcoreguidelines-prefer-member-initializer issues

lucafedeli88 · Oct 24, 2024 · dc1aa24 · dc1aa24
1 parent 822a8a0
commit dc1aa24
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/multi_physics/QED/include/picsar_qed/physics/breit_wheeler/breit_wheeler_engine_tables.hpp b/multi_physics/QED/include/picsar_qed/physics/breit_wheeler/breit_wheeler_engine_tables.hpp
@@ -221,10 +221,9 @@ namespace picsar::multi_physics::phys::breit_wheeler
             m_table{containers::equispaced_1d_table<RealType, VectorType>{
                     math::m_log(params.chi_phot_min),
                     math::m_log(params.chi_phot_max),
-                    vals}}
-            {
-                m_init_flag = true;
-            }
+                    vals}},
+            m_init_flag{true}
+            {}
 
             /*
             * Generates the content of the lookup table (not usable on GPUs).
@@ -432,9 +431,9 @@ namespace picsar::multi_physics::phys::breit_wheeler
 
         protected:
             dndt_lookup_table_params<RealType> m_params; /* Table parameters*/
-            bool m_init_flag = false; /* Initialization flag*/
             containers::equispaced_1d_table<
                 RealType, VectorType> m_table; /* Table data */
+            bool m_init_flag = false; /* Initialization flag*/
 
         private:
             /*

diff --git a/...physics/QED/include/picsar_qed/physics/quantum_sync/quantum_sync_engine_tables_detail.hpp b/...physics/QED/include/picsar_qed/physics/quantum_sync/quantum_sync_engine_tables_detail.hpp
@@ -396,12 +396,14 @@ namespace picsar::multi_physics::phys::quantum_sync::detail
         PXRMP_GPU_QUALIFIER PXRMP_FORCE_INLINE
         ITailOptFunctor(const int zsize, const int zfirst,
             const RealType zmin, const RealType zmax, const RealType zswitch) :
-                m_zsize{zsize}, m_zfirst{zfirst}, m_zmin{zmin}, m_zswitch{zswitch}
-        {
-            m_exp_zswitch = math::m_exp(zswitch);
-            m_coeff_first = (zfirst - 1) / (zswitch - zmin);
-            m_coeff_second = (zsize - zfirst) / (math::m_exp(zmax) - m_exp_zswitch);
-        }
+            m_zsize{zsize},
+            m_zfirst{zfirst},
+            m_zmin{zmin},
+            m_zswitch{zswitch},
+            m_exp_zswitch{math::m_exp(zswitch)},
+            m_coeff_first{(zfirst - 1) / (zswitch - zmin)},
+            m_coeff_second{(zsize - zfirst) / (math::m_exp(zmax) - m_exp_zswitch)}
+        {}
 
         /**
         * Operator()