Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#260 - feat: allow filter by client alone on report #261

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

lucassabreu
Copy link
Owner

related to #260

@lucassabreu lucassabreu self-assigned this Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 60.32%. Comparing base (dd33e38) to head (b1ae40b).

Files Patch % Lines
pkg/search/project.go 0.00% 21 Missing ⚠️
api/client.go 0.00% 8 Missing ⚠️
pkg/cmd/time-entry/report/util/report.go 91.11% 2 Missing and 2 partials ⚠️
api/httpClient.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   60.56%   60.32%   -0.25%     
==========================================
  Files          56       56              
  Lines        3827     3879      +52     
==========================================
+ Hits         2318     2340      +22     
- Misses       1417     1444      +27     
- Partials       92       95       +3     
Flag Coverage Δ
unittests 60.32% <54.54%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucassabreu lucassabreu merged commit 5fd41ed into main Mar 29, 2024
7 of 11 checks passed
@lucassabreu lucassabreu deleted the issue/260 branch March 29, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant