Address CI failures #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e10harvey
force-pushed
the
half_cleanup
branch
from
5245b3b
to
935e9bf
Compare
lucbv
reviewed
Oct 2, 2023
| #if KOKKOS_VERSION < 40199 | ||
| KOKKOS_IMPL_DO_NOT_USE_PRINTF("NaN is not NaN\n"); | ||
| KOKKOS_IMPL_DO_NOT_USE_PRINTF("NaN is not NaN\n"); |
There was a problem hiding this comment.
This is not running on device as far as I can tell so why not use std::cout instead of the device Kokkos::printf()?
lucbv
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lucbv