enforce env var LUCEE_ADMIN_MODE

lucee · Aug 6, 2024 · 14142b7 · 14142b7
1 parent eaa54b1
commit 14142b7
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/core/src/main/java/lucee/runtime/config/ConfigWebFactory.java b/core/src/main/java/lucee/runtime/config/ConfigWebFactory.java
@@ -3582,8 +3582,23 @@ private static void _loadUpdate(ConfigServer configServer, Config config, Struct
 	 * @param doc
 	 */
 	private static void _loadAdminMode(ConfigServerImpl config, Struct root) {
-		config.setAdminMode(
-				ConfigWebUtil.toAdminMode(getAttr(root, "mode"), Caster.toShortValue(SystemUtil.getSystemPropOrEnvVar("lucee.admin.mode", null), ConfigImpl.ADMINMODE_SINGLE)));
+		final short undefined = -1;
+		short am = undefined;
+
+		// force by env var
+		String str = SystemUtil.getSystemPropOrEnvVar("lucee.admin.mode", null);
+		if (!StringUtil.isEmpty(str, true)) {
+			am = ConfigWebUtil.toAdminMode(str, undefined);
+		}
+
+		// when not forced
+		if (am == undefined) {
+			am = ConfigWebUtil.toAdminMode(getAttr(root, "mode"), undefined);
+			if (am == undefined) {
+				am = ConfigWebUtil.toAdminMode(SystemUtil.getSystemPropOrEnvVar("lucee.admin.mode.default", null), ConfigImpl.ADMINMODE_SINGLE);
+			}
+		}
+		config.setAdminMode(am);
 	}
 
 	private static void _loadSetting(ConfigServerImpl configServer, ConfigImpl config, Struct root, Log log) {

diff --git a/loader/build.xml b/loader/build.xml
@@ -2,7 +2,7 @@
 <project default="core" basedir="." name="Lucee" 
   xmlns:resolver="antlib:org.apache.maven.resolver.ant">
 
-  <property name="version" value="6.0.4.4-SNAPSHOT"/>
+  <property name="version" value="6.0.4.5-SNAPSHOT"/>
 
   <taskdef uri="antlib:org.apache.maven.resolver.ant" resource="org/apache/maven/resolver/ant/antlib.xml">
     <classpath>

diff --git a/loader/pom.xml b/loader/pom.xml
@@ -3,7 +3,7 @@
 
   <groupId>org.lucee</groupId>
   <artifactId>lucee</artifactId>
-  <version>6.0.4.4-SNAPSHOT</version>
+  <version>6.0.4.5-SNAPSHOT</version>
   <packaging>jar</packaging>
 
   <name>Lucee Loader Build</name>