Merge pull request #2352 from MitrahSoft/LDEV_4827_

improve test cases
lucee · Apr 22, 2024 · 1e35382 · 1e35382
2 parents 2c0ae8e + bd4645f
commit 1e35382
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/test/tickets/LDEV4827.cfc b/test/tickets/LDEV4827.cfc
@@ -1,12 +1,12 @@
 component extends="org.lucee.cfml.test.LuceeTestCase" {
 
     function beforeAll() {
-        variables.mssql= getCredentials();
+        variables.mssql = getCredentials();
     }
 
     function run( testResults , testBox ) {
         describe( "Test suite for LDEV-4827", function() {
-            it( title='Checking Query with real result on mssql',body = function( currentSpec ) {
+            it( title='Checking Query with real result on mssql', skip=checkMySqlEnvVarsAvailable(), body=function( currentSpec ) {
                 adm = new Administrator('server', request.SERVERADMINPASSWORD?:server.SERVERADMINPASSWORD);
                 adm.updateDatasource(
                     name: 'datasource4827',
@@ -36,6 +36,10 @@ component extends="org.lucee.cfml.test.LuceeTestCase" {
         });
     }
 
+    private boolean function checkMySqlEnvVarsAvailable() {
+        return (StructCount(server.getDatasource("mssql")) eq 0);
+    }
+
     private struct function getCredentials() {
         // getting the credentials from the environment variables
         var mssql = {};